feat: add 'deprecated' field for depreacted section generation in image docs #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zhijie-yang
requested changes
Nov 13, 2024
linostar
force-pushed
the
ROCKS-1224/feat/support-deprecated-channels
branch
from
02ae05f to
1594b0a
Compare
|
@clay-lake @zhijie-yang This is ready for review. The result can be seen on Dockerhub's mock-rock page, where track |
|
|
zhijie-yang
approved these changes
Nov 19, 2024
clay-lake
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping the @canonical/rocks team.
Description
The documentation generator for rocks is missing some parts necessary to generate the
Deprecated channels & tagssection.This PR provides the necessary values so that the generator can identify the deperacted tags and list them accordingly, using the expired end-of-life value of each track to determine whether it is depreacted or not.
Related issues
OCI-Factory builds won't work if one image's track has an expired EOL value. Another PR to fix that issue will be out soon.